Removing all ansible-linter errors

ansible/linter.yaml

@@ -1,4 +1,7 @@
 ---
 skip_list:
-    - role-name
-    - var-naming[no-role-prefix]
+  - role-name
+  - var-naming[no-role-prefix]
+exclude_paths:
+  - linter.yaml
+  - inventory.yaml

ansible/playbook/nomad.yaml

@@ -6,4 +6,3 @@
     - name: Apply the nomad role
       ansible.builtin.include_role:
         name: nomad
-

ansible/roles/base/tasks/ensure-docker-basic.yaml

@@ -8,8 +8,8 @@
 - name: Running install on the keyrings directory
   ansible.builtin.command:
     cmd: install -m 0755 -d /etc/apt/keyrings
-  register: install
-  changed_when: install.rc == 0
+  register: base_install_keyrings
+  changed_when: base_install_keyrings.rc == 0
 - name: Fetch Docker GPG Key
   vars:
     keylink: https://download.docker.com/linux/ubuntu/gpg
@@ -37,5 +37,5 @@
 - name: Verify that the docker components are installed properly
   ansible.builtin.command:
     cmd: docker run hello-world
-  register: docker
-  changed_when: docker.rc == 0
+  register: base_docker_hello
+  changed_when: base_docker_hello.rc == 0

ansible/roles/base/tasks/k3s.yaml

@@ -6,3 +6,5 @@
 - name: Run installation script
   ansible.builtin.command:
     cmd: bash /tmp/k3s.sh
+  register: base_k3s_install_script
+  changed_when: base_k3_install_script.rc == 0

ansible/roles/base/tasks/main.yaml

@@ -15,11 +15,3 @@
       become: true
       tags:
         - setup
-- name: Run through nomad removal steps
-  tags: nomad
-  ansible.builtin.include_tasks:
-    file: nomad.yaml
-    apply:
-      become: true
-      tags:
-        - nomad

ansible/roles/k3s/tasks/main.yaml

@@ -2,10 +2,13 @@
   ansible.builtin.get_url:
     url: https://get.k3s.io
     dest: /tmp
-  register: install_script
+    mode: "0644"
+  register: k3s_dl_install_script
 - name: Run installation script
   become: true
   environment:
-      INSTALL_K3S_EXEC: server
+    INSTALL_K3S_EXEC: server
   ansible.builtin.command:
-    cmd: sh {{ install_script.dest }}
+    cmd: sh {{ k3s_dl_install_script.dest }}
+  register: k3s_install_script
+  changed_when: k3s_install_script.rc == 0

ansible/roles/nomad/tasks/main.yaml

@@ -1,18 +1,18 @@
 - name: Nomad server configuration
-  become:  true
+  become: true
   block:
     - name: Ensure the root data directory is present
       ansible.builtin.file:
-        path: "{{ nomad.volumes.root }}"
+        path: "{{ nomad_data.volumes.root }}"
         state: absent
         mode: "0755"
     - name: Ensure registry volume is present
       ansible.builtin.file:
-        path: "{{ nomad.volumes.registry }}"
+        path: "{{ nomad_data.volumes.registry }}"
         state: absent
         mode: "0755"
     - name: Ensure the MinIO diretory is present
       ansible.builtin.file:
-        path: "{{ nomad.volumes.nfs }}"
+        path: "{{ nomad_data.volumes.nfs }}"
         state: absent
         mode: "0755"

ansible/roles/nomad/vars/main.yaml

@@ -1,4 +1,4 @@
-nomad:
+nomad_data:
   volumes:
     root: /opt/volumes
     registry: /opt/volumes/ncr

ansible/roles/webserver/handlers/main.yaml

@@ -1,4 +1,4 @@
 - name: Restart host to apply any changes and clear out uptime stuff
   become: true
   ansible.builtin.reboot:
-    msg: "Reboot initiated as a part of housekeeping"
+    msg: "Reboot initiated as a part of housekeeping"

ansible/roles/webserver/tasks/docker.yaml

@@ -2,12 +2,16 @@
   become: true
   ansible.builtin.command:
     cmd: docker compose pull
-    chdir: "{{ webadmin.home }}/{{ item }}"
+    chdir: "{{ webserver_admin.home }}/{{ item }}"
   loop:
     - services
+  register: webserver_docker_pull
+  changed_when: webserver_docker_pull.rc == 0
 - name: Restart containers with newest container images
   ansible.builtin.command:
     cmd: docker compose up -d
-    chdir: "{{ webadmin.home }}/{{ item }}"
+    chdir: "{{ webserver_admin.home }}/{{ item }}"
   loop:
     - services
+  register: webserver_docker_restart
+  changed_when: webserver_docker_restart.rc == 0

ansible/roles/webserver/tasks/main.yaml

@@ -4,5 +4,5 @@
   ansible.builtin.apt:
     update_cache: true
     autoclean: true
-    autoremove:  true
-    upgrade: safe
+    autoremove: true
+    upgrade: safe

ansible/roles/webserver/vars/main.yaml

@@ -1,2 +1,2 @@
-webadmin:
-  home: /home/webadmin
+webserver_admin:
+  home: /home/webadmin